search

terrestris / shogun-legacy

⛔️ DEPRECATED, please use https://github.com/terrestris/shogun-core
Other
16 stars 16 forks source link

Migration to Spring 4 #61

Closed buehner closed 8 years ago

buehner commented 9 years ago

This simple pull request migrates SHOGun to Spring 4 and Spring Security 4.

We are currently using the spring-4 branch of SHOGun in a (big) project and everything seems to be fine.

Would be great if someone could review and test this branch with another application before merging.

http://docs.spring.io/spring-security/site/migrate/current/3-to-4/html5/migrate-3-to-4-xml.html

:beers:

ahennr commented 8 years ago

THX @buehner .

I used this branch in my application as well. As far as I can see, updating Spring (3.2.11.RELEASE -> 4.2.3.RELEASE) and Spring Security (3.2.5.RELEASE -> 4.0.3.RELEASE) didn't conflict with your changes.

Nevertheless, IMO the Spring config files (especially applicationContext-security.xml) also need to be updated as well, since there are some changes mentioned in the migration guide. Or am I wrong at this point?

buehner commented 8 years ago

Thx for your fixes @ahennr !

I just created a new release https://github.com/terrestris/shogun/releases/tag/v0.3 for people that still rely on the current state of SHOGun.

I think it would be great, if @marcjansen and @chrismayer could have a quick look at this before merging.

marcjansen commented 8 years ago

I have added two comments, otherwise this looks good to me. I am :+1: for merging.

Please give @chrismayer at least 2 days to give his :+1: or :-1:.

buehner commented 8 years ago

Thx @ahennr . Let's wait a bit more for @chrismayer before merging.

chrismayer commented 8 years ago

Hi all, the changesets are looking good to me. I am :+1: for merging this. Thanks for tackling this!

ahennr commented 8 years ago

Will merge now

marcjansen commented 8 years ago

Thanks for the work and the reviews, gentlemen.