Deprecate DFIndexer - Githubissues

terrier-org / pyterrier

A Python framework for performing information retrieval experiments, building on http://terrier.org/

https://pyterrier.readthedocs.io/

Mozilla Public License 2.0

420 stars 65 forks source link

Deprecate DFIndexer #457

Closed cmacdonald closed 3 months ago

cmacdonald commented 3 months ago

WIP deprecating DFIndexer:

Problems remaining

[x] update indexing.ipynb
[x] fix text.scorer (may require pt.IterDictIndexer to accept memory as a target)

cmacdonald commented 3 months ago

it shows lots of commits, but its only 7 files changed thus far

cmacdonald commented 3 months ago

This PR deprecates DFIndexer, and is now ready for review. I'm not sure if needs to be rebased, as it shows all the Java branch changes for some reason.

seanmacavaney commented 3 months ago

rebased

cmacdonald commented 3 months ago

i want to reexecute the notebook without all the INFO log messages before committing

cmacdonald commented 3 months ago

I think this can be merged now