terrylinla / react-native-sketch-canvas

A React Native component for drawing by touching on both iOS and Android.
MIT License
693 stars 450 forks source link

Android devices ALWAYS prompt user for Write permissions (even when unnecessary) #100

Open toblerpwn opened 5 years ago

toblerpwn commented 5 years ago
screen shot 2019-02-07 at 4 49 22 pm

Only some paths require write permissions to be explicitly prompted for--e.g. external storage, as is prompted here.

I am honestly unsure the actual use case here, but the request for permissions should be:

  1. Only performed when actually required, e.g. a path outside the typical save area is specified.
  2. Should only be shown when the SAVE action is taken--not upon initialization.
m4yer commented 3 years ago

I've tried to find any fork that fixed that issue but couldn't succeed so I created my own containing only this fix. I am too lazy to create npm package so if you want to use this you can just use the following:

npm i m4yer/react-native-sketch-canvas

Then use the component like this:

<SketchCanvas
    promptForExternalWritePermissions={false}
/>