search

terryworona / TWMessageBarManager

An iOS manager for presenting system-wide notifications via a dropdown message bar.
MIT License
1.77k stars 191 forks source link

Two large or wrongly positioned message on landscape iPad app with iOS 8 #73

Closed gtennis closed 9 years ago

gtennis commented 9 years ago

Message is shown of full screen iPad portrait size on iPad landscape app with iOS 8. Tried with iPad 2 (iOS 8) simulator. Success message type. I didn't find any info about it being not supported for iPad, therefore wondering has anybody tried it to use on iPad?

gtennis commented 9 years ago

Now it works. Used @ivanharmat suggested fix: https://github.com/terryworona/TWMessageBarManager/issues/59

gtennis commented 9 years ago

It would be nice this fix to be merged into regular branch. Otherwise it will be overwritten next time we perform pod install. Usually I'm using dynamic pod versions therefore I need to add this change somewhere else. Tried to subclass TWMessageView and override method but TWMessageView is declared in manager class implementation therefore there no access to it.

terryworona commented 9 years ago

@centurionas you want to submit a PR for this fix?

terryworona commented 9 years ago

Pulled in this manually via commit: 581a116f5759f66f191218a99d669fb4db9678c3

gtennis commented 9 years ago

Thanks @terryworona for excellent library. Now it works. Though I'm wondering why it's showing 1.7.2 version in cocoa pods and my pods file contains "pod 'TWMessageBarManager', '~> 1.7'". But when I run pod install it's written "Installing TWMessageBarManager 1.7.0 (was 1.7.0)". Should it be saying "1.7.2" when installing pod?

cdzombak commented 9 years ago

Though I'm wondering why it's showing 1.7.2 version in cocoa pods and my pods file contains "pod 'TWMessageBarManager', '~> 1.7'". But when I run pod install it's written "Installing TWMessageBarManager 1.7.0 (was 1.7.0)". Should it be saying "1.7.2" when installing pod?

What's in your Podfile.lock? If you have previously installed 1.7.0, pod install won't update it for you—either change your Podfile to require pod 'TWMessageBarManager', '~> 1.7.2' or run pod update.

terryworona commented 9 years ago

@centurionas - change your podfile to:

pod 'TWMessageBarManager'

or

pod 'TWMessageBarManager', '~> 1.7.2'