teslamotors / helm-charts

10 stars 7 forks source link

Configuration May Contain Secrets #32

Open joelbixbyrevel opened 9 months ago

joelbixbyrevel commented 9 months ago

Issue

For those using SASL authentication Kafka, current configuration file may contain authentication secrets.

  "kafka": { //librdkafka kafka config, seen here: https://raw.githubusercontent.com/confluentinc/librdkafka/master/CONFIGURATION.md
    "bootstrap.servers": "kafka:9092",
    "queue.buffering.max.messages": 1000000,
    "sasl.username":  "MyUsername",
    "sasl.password": "MyPassword"
  },

Expectation

SASL credentials have a place in secure storage.

joelbixbyrevel commented 9 months ago

Not seeing any clear workarounds for this one. I could see this being solved by moving configuration to the secrets template. Otherwise maybe some coordination required between fleet-telemtery codebase to support credentials outside of this configuration.