search

tesshucom / jpsonic

This is a repository for development. See https://github.com/jpsonic/jpsonic
GNU General Public License v3.0
14 stars 13 forks source link

French-specific message bug #1824

Closed tesshucom closed 2 years ago

tesshucom commented 2 years ago

i18n considerations. Related airsonic/airsonic#1769, airsonic/airsonic#1837, #1744

It's probably due to single quotes. I remember fixing it, but... just to confirm.

tesshucom commented 2 years ago

after, installation, I can see welcome message in french I want click on the link "don't see this message again"....

image

but no works !

As you say. doesn't seem to work.

image

Reproduced. It will be fixed in v111.6.0.

tesshucom commented 2 years ago

Two reasons:

Wrong tag

As of Airsonic, the tag is wrong only in French.

https://github.com/airsonic/airsonic/blob/5ccca059d5cfe3dd19734c27861b434ea21b43d8/airsonic-main/src/main/resources/org/airsonic/player/i18n/ResourceBundle_fr.properties#L156

Forgot to close double quotes

In Jpsonic, tags are not closed in all languages except Japanese and Brazilian.

<a href="https://airsonic.github.io/docs/>

These will be fixed.

tesshucom commented 2 years ago

There was another :joy::joy::joy::joy:

https://github.com/airsonic/airsonic/blob/5ccca059d5cfe3dd19734c27861b434ea21b43d8/airsonic-main/src/main/resources/org/airsonic/player/i18n/ResourceBundle_fr.properties#L158

Alert message displayed when clicking a link is causing JavaScript to malfunction due to double quotes. (link not working)

This will be addressed in JSP.