test-kitchen / kitchen-ec2

A Test Kitchen Driver for Amazon EC2
Other
222 stars 202 forks source link

feat: Implements placement options and license specifications #615

Closed mfortin closed 10 months ago

mfortin commented 10 months ago

Description

Implements placement options and license specifications

Issues Resolved

591

tenancy: dedicated may not be sufficient for all use cases. Adding options to set placement host resource group arn and license configurations may be required in some advanced use cases.

Type of Change

feat: Add placement options and License Specifications

Check List

mfortin commented 10 months ago

@damacus fixed the code

damacus commented 10 months ago

Looks like we've got a small diff in the test now. Which is probably expected?


       @@ -2,9 +2,10 @@
        :image_id => nil,
        :instance_type => nil,
        :key_name => nil,
       +:licenses => [{:license_configuration_arn=>"arn:aws:ec2:us-east-1:123456789012:license-configuration/my-license"}],
        :max_count => 1,
        :min_count => 1,
       -:placement => {:availability_zone=>"eu-east-1c", :tenancy=>"dedicated"},
       +:placement => {:host_resource_group_arn=>"arn:aws:ec2:us-east-1:123456789012:resource-group/my-group"},
        :private_ip_address => nil,
        :subnet_id => nil,
     # ./spec/kitchen/driver/aws/instance_generator_spec.rb:694:in `block (5 levels) in <top (required)>'
damacus commented 10 months ago

Thanks!