testcontainers / testcontainers-jooq-codegen-maven-plugin

jOOQ code generator using Testcontainers
Apache License 2.0
62 stars 13 forks source link

Not properly declaring dependencies #48

Open bitxon opened 1 month ago

bitxon commented 1 month ago

Description Maven project that uses testcontainers-jooq-codegen-maven-plugin always print a WARNING


Steps to Reproduce

  1. Add testcontainers-jooq-codegen-maven-plugin to your project

    <build>
    <plugins>
        <plugin>
            <groupId>org.testcontainers</groupId>
            <artifactId>testcontainers-jooq-codegen-maven-plugin</artifactId>
            <version>0.0.4</version>
            ...
        </plugin>
    </plugins>
    </build>
  2. Build your project

    ./mvnw clean verify -Dmaven.plugin.validation=VERBOSE
  3. See Warning in build log (console)

    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time:  31.246 s
    [INFO] Finished at: 2025-04-06T13:36:26+02:00
    [INFO] ------------------------------------------------------------------------
    [WARNING] 
    [WARNING] Plugin validation issues were detected in 1 plugin(s)
    [WARNING] 
    [WARNING]  * org.testcontainers:testcontainers-jooq-codegen-maven-plugin:0.0.4
    [WARNING]   Declared at location(s):
    [WARNING]    * bitxon:spring-jooq-postgres:0.0.1-SNAPSHOT (pom.xml) @ line 93
    [WARNING]   Used in module(s):
    [WARNING]    * bitxon:spring-jooq-postgres:0.0.1-SNAPSHOT (pom.xml)
    [WARNING]   Plugin issue(s):
    [WARNING]    * Plugin should declare these Maven artifacts in `provided` scope: [org.apache.maven:maven-builder-support:3.9.0, org.apache.maven:maven-model-builder:3.9.0, org.apache.maven:maven-core:3.9.0, org.apache.maven:maven-repository-metadata:3.9.0, org.apache.maven:maven-plugin-api:3.9.0, org.apache.maven:maven-resolver-provider:3.9.0, org.apache.maven:maven-settings:3.9.0, org.apache.maven:maven-artifact:3.9.0, org.apache.maven:maven-model:3.9.0, org.apache.maven:maven-settings-builder:3.9.0]
    [WARNING] 
    [WARNING] 
    [WARNING] Fix reported issues by adjusting plugin configuration or by upgrading above listed plugins. If no upgrade available, please notify plugin maintainers about reported issues.
    [WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
    [WARNING] 
bitxon commented 1 month ago

I have prepared PR that supposed to fix the issue https://github.com/testcontainers/testcontainers-jooq-codegen-maven-plugin/pull/49

<dependency>
  <groupId>org.apache.maven</groupId>
  <artifactId>maven-plugin-api</artifactId>
  <version>${maven-plugin-api.version}</version>
  <scope>provided</scope> <!-- specify provided scope -->
</dependency>
<dependency>
  <groupId>org.apache.maven</groupId>
  <artifactId>maven-core</artifactId>
  <version>${maven-core.version}</version>
  <scope>provided</scope> <!-- specify provided scope -->
</dependency>