search

testing-cabal / unittest-ext

Automatically exported from code.google.com/p/unittest-ext
2 stars 2 forks source link

extras_require key breaks setup.py with older setuptools #98

Closed mcepl closed 8 years ago

mcepl commented 8 years ago

With RHEL-7 I have python-setuptools 0.9.8-4 and it breaks:

# python setup.py build
error in unittest2 setup command: Invalid environment marker: python_version<="2.6"
#

I would think that this key of setup() command should go.

rbtcollins commented 8 years ago

We need that to handle python version differences, sorry - there are workarounds that can be used, but the best is to use a more recent setuptools: if you're installing unittest2 globally, upgrade setuptools globally. If you're installing in a virtualenv, upgrade setuptools in your virtualenv first. We could possibly version-check setuptools ourselves and throw an error, but we had pretty average results doing that with mock.

mcepl commented 8 years ago

Well, I hoped, that I could find here some help with #97 so I was willing to upgrade unittest to the master here. Apparently, I won't get any help, so I will have to create fix myself anyway, there is no reason not to patch RHEL package instead (yes, when if I find out something, I will provide patch here).