search

testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

Update @testing-library/dom #260

Open zenblender opened 1 year ago

zenblender commented 1 year ago

Problem description:

Should this be updated with the latest @testing-library/dom? (Currently 9.3.1)

I’ve noticed incompatibilities with other libraries that use the latest version of @testing-library/dom, such as @testing-library/react and @testing-library/user-event. Having both versions 8 and 9 in a project causes confusion and errors, for example about whether user-event actions need to be wrapped in act.

Suggested solution:

Update cypress-testing-library to use the latest version of @testing-library/dom.

radoslawgrochowski commented 11 months ago

Bumping.

Because of difference between versions of @testing-library/react and @testing-library/cypress I've got error like you mentioned.

console.error
  Warning: The current testing environment is not configured to support act(...)

I see there is pending PR https://github.com/testing-library/cypress-testing-library/pull/262 .

Since it looks like there is no breaking change between versions, I'm working with pnpm.packageExtensions till there is version bump:

"pnpm": {
  "packageExtensions": {
    "@testing-library/cypress@9.0.0": {
      "dependencies": {
        "@testing-library/dom": "^9.0.0"
      }
    }
  }
}