Closed MatanBobi closed 1 year ago
codesandbox-ci[bot]
commented
1 year ago This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit b1c1dd0bb362481f1c5cab8d882d93494d01757a:
| Sandbox | Source |
|---|---|
| react-testing-library-examples | Configuration |
codecov[bot]
commented
1 year ago Merging #1237 (b1c1dd0) into main (d09b3c2) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #1237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1038 1038
Branches 346 349 +3
=========================================
Hits 1038 1038 | Flag | Coverage Ξ | |
|---|---|---|
| node-14 | 100.00% <ΓΈ> (ΓΈ) |
|
| node-16 | 100.00% <ΓΈ> (ΓΈ) |
|
| node-18 | 100.00% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
wojtekmaj
commented
9 months ago Please note that by pinning the package, an update to aria-query, replacing bloated deep-equal dependency with a much smaller alternative dequal, cannot be used. It would be beneficial for the project to fix the issues mentioned in the first comment in aria-query if possible.
MatanBobi
commented
9 months ago Hi @wojtekmaj :) We're working on upgrading aria-query in our next major, afair, it's already merged in the alpha branch.
What: Temporarily pinning
aria-queryto version 5.1.3.Why: The new version of
aria-query(5.2.1) was released yesterday and caused a few issues on our end. Affected issues: Fixes https://github.com/testing-library/dom-testing-library/issues/1235 Fixes https://github.com/testing-library/dom-testing-library/issues/1238How: Pinning the version in package.json.
Checklist:
TypeScript definitions updated