testing-library / eslint-plugin-testing-library

ESLint plugin to follow best practices and anticipate common mistakes when writing tests with Testing Library
https://npm.im/eslint-plugin-testing-library
MIT License
992 stars 142 forks source link

`await-async-events` doesn't seem to check calls from user sessions returned by userEvent.setup() #812

Open julienw opened 1 year ago

julienw commented 1 year ago

What rule do you want to change?

await-async-events

Does this change cause the rule to produce more or fewer warnings?

More warnings

How will the change be implemented?

The code needs to detect calls to userEvent.setup() and calls to the resulting object's methods.

Example code

import userEvent from '@testing-library/user-event';
const user = userEvent.setup();
user.click(domElement);

How does the current rule affect the code?

user.click() and others returns a Promise and should be awaited.

How will the new rule affect the code?

import userEvent from '@testing-library/user-event';
const user = userEvent.setup();
await user.click(domElement);

Anything else?

see also https://github.com/testing-library/eslint-plugin-testing-library/issues/800

Do you want to submit a pull request to change the rule?

No

Kvanttinen commented 1 year ago

Any estimate for this? We're about to start using this package in our project and this is a blocker for us.

I'm using @testing-library/user-event 14.5.1 and eslint-plugin-testing-library 6.1.0.

Belco90 commented 1 year ago

There is no ETA for this. PRs are more than welcome 🙂.

Kvanttinen commented 1 year ago

Ok, I was already looking for a solution for that yesterday, I'll see if I can come up with something.

gerardo-rodriguez commented 3 months ago

I'd love to see this as well. Are there any more recent updates on this? Thanks, everyone! 😄