search

testing-library / svelte-testing-library

:chipmunk: Simple and complete Svelte DOM testing utilities that encourage good testing practices
https://testing-library.com/docs/svelte-testing-library/intro
MIT License
614 stars 33 forks source link

Semantic Pull Requests is no longer maintained #192

Closed yanick closed 7 months ago

yanick commented 2 years ago

https://github.com/zeke/semantic-pull-requests#readme

And indeed it doesn't seem to be running at all.

From the README, it seems we should be able to add a semantic.yml file with enabled: false to bypass the action. But we also need to add a replacement (the README also has alternatives. Must look at them)

yanick commented 2 years ago

I've merged #193 to main so that we have an active semantic checker, but it seems that setting the config of Semantic Pull Request to disable is not enough to keep it at bay. The problem is that I don't know whose account has enabled that service for this repo. So until we find that, I guess we'll have to merge things using the override.

(and I changed the config of the repo so that squashed merges use the title of the PR as their commit message, so that the whole semantic stuff work)

mcous commented 8 months ago

@yanick do you have access to the repository settings? The "Semantic Pull Requests" requirement is set - and thus can be removed - via branch protection rules on the main branch.

If not, do you know who we could ping that does have admin access to the repo? This is gonna be quite annoying for continuing maintenance

yanick commented 8 months ago

I do, I do have access to the settings! \o/ I must have gotten those powers when I submitted changes to the documentation repo. I'll go and peek in the config after breakfast.

yanick commented 8 months ago

Aaaand it should be disabled, now. We'll see for sure at the next PR. :crossed_fingers:

mcous commented 8 months ago

PRs have been running smoothly 🚢, I think we can call this one resolved

yanick commented 7 months ago

Yup. Closing!