search

testing-library / testcafe-testing-library

:ox: Simple and complete custom Selectors for Testcafe that encourage good testing practices.
http://npm.im/@testing-library/testcafe
MIT License
71 stars 15 forks source link

revert: "chore: rename default branch to main (#295)" #348

Closed Hagendorn closed 2 years ago

Hagendorn commented 2 years ago

This reverts commit 965fb0423b624f703059b3291069bc4984b84c6d.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nickserv commented 2 years ago

Is there a specific reason this needed to be reverted? If not, I'd prefer to use main, as it's consistent with GitHub's and Testing Library's newer naming conventions.

Hagendorn commented 2 years ago

The automatic release did not work anymore when a commit was merged to main. I did not found the reason and I found no time to rename it to main again. But sure there is no reason to stay with master.

nickserv commented 2 years ago

Oh, I think that's because semantic release doesn't enable the main branch by default. I'll try to fix it in #369 soon.