search

testing-library / testing-playground

Simple and complete DOM testing playground that encourage good testing practices.
https://testing-playground.com
MIT License
782 stars 62 forks source link

Testing Playground breaks Miro #351

Open chodorowicz opened 1 year ago

chodorowicz commented 1 year ago

Bug Report 🐛

Testing Playground breaks Miro

Cannot read properties of undefined (reading 'startAppLoadingStep')

https://community.miro.com/ask-the-community-45/miro-broken-when-used-with-testing-library-extension-9916

CleanShot 2022-09-23 at 09 55 49

To Reproduce ✔️

  1. Install Testing Playground Extension
  2. Access Miro Board

Expected behavior 🤔

Miro should load correctly.

Suggested solution 🔦

Setting the extension to load on click fixes the problem.

Your Environment 💻

smeijer commented 1 year ago

It must be one of the patched methods on window that's causing issues. I'm happy to accept a pull that makes it safer by namespacing or even adding it behind an init function. Something like window.initTestingLibrary();

https://github.com/testing-library/testing-playground/blob/d85b47ac80a2343a921f572166360fc7d8f541c5/devtools/src/window/testing-library.js#L26-L41

sersorrel commented 1 year ago

It's not that; I commented out the entire setup function and it's still broken.

The issue occurs when testing-library.js is injected.