search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.09k stars 109 forks source link

Question about (engine property) in the package.json file #129

Closed rzkhosroshahi closed 4 years ago

rzkhosroshahi commented 4 years ago

Hello I have a question Why did you add engine property in the package.json file? I have an issue with this because it makes an error in my ci/cd. that issue is my node engine version is not compatible whit engine that you added in package.json file and pipeline break up.

afontcu commented 4 years ago

Hi!

What node version is your CI/CD pipeline running on?

rzkhosroshahi commented 4 years ago

Hey. its 8 version

afontcu commented 4 years ago

Then that's the reason 😄 In v5.0 we dropped support for Node 8, since it is out of LTS and we updated DOM Testing Library.

I guess you'd need to update your CI to support LTS node versions!

I'm closing this, but thanks for filling this in! Have a great week 😃