afontcu commented 4 years ago

@nickmccurdy just saw that #155 was failing on CI and noticed it was due to eslint rules. So I took a stab at it and fixed the errors – if you still think we should remove package-lock, I'll happily remove it in this PR, or merge this one and then yours should pass.

Oh, and by the way – should this PR trigger a (minor?) release, since types and DTL have been updated?

codecov[bot] commented 4 years ago

Codecov Report

Merging #156 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           70        70           
  Branches        13        13           
=========================================
  Hits            70        70

Impacted Files	Coverage Δ
src/vue-testing-library.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76cdc70...5233a9a. Read the comment docs.

afontcu commented 4 years ago

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

testing-library / vue-testing-library

Update deps #156

Codecov Report