Tutorial Review for Tethys 4.3

swainn commented 1 month ago

Description

This pull request include updates to all of the tutorials after a complete review. This update was necessary because of the changes to the app scaffold and other changes in Tethys 4.3. It also includes a few code changes that address issues discovered while reviewing the tutorials.

Changes Made to Code:

All tutorials were reviewed and updated
Key Concepts tutorial was refactored to use the Map Layout instead of the Map View Gizmo for the primary map view. It still illustrates how to use the Map View Gizmo in forms.
Added screenshots to the Key Concepts tutorial to match the style of the newer tutorials.
Fixed a CSS issue in the app base template that prevented the Map View Gizmo from displaying when height was set to 100%.
Linted the default app scaffold template.
Fixed an issue with the map tabs content area on the Map Layout that was causing the page to have a scroll bar.

Quality Checks

[] New code is 100% tested
[] Code has been formatted
[] Code has been linted
[] Docstrings for new methods have been added

coveralls commented 1 month ago

coverage: 99.936%. remained the same when pulling d1757b9b694b6c4dd388b72cda7da0b3927dcf83 on tutorial-review-43 into 1a761f2d4abd537c5b99bd2d18481c7619da0e2c on main.

sdc50 commented 3 weeks ago

@swainn how do you access the docs build for a PR again?

sdc50 commented 3 weeks ago

I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the quotas-solution branch, that remove all of the code that the tutorial says to add.

swainn commented 3 weeks ago

@swainn how do you access the docs build for a PR again?

It's the details link next to the docs/readthedocs.org:tethys-platform check (near the bottom).

swainn commented 3 weeks ago

I'm not allowed officially approve, since I have commits in this PR, but I approve.

I rescind my approval. I pulled up the check build of the docs and noticed that the logo looks terrible:

Remove the "Tethys Platform" text and use some custom CSS to make the logo bigger.

swainn commented 3 weeks ago

I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the quotas-solution branch, that remove all of the code that the tutorial says to add.

@jakeymac please look into this.

jakeymac commented 3 weeks ago

I'm confused about what is happening with the quotas tutorial. It looks like changes where made to the quotas-solution branch, that remove all of the code that the tutorial says to add.

@sdc50 I've updated the tutorial.

swainn commented 3 weeks ago

I'm not allowed officially approve, since I have commits in this PR, but I approve.

I rescind my approval. I pulled up the check build of the docs and noticed that the logo looks terrible:

Remove the "Tethys Platform" text and use some custom CSS to make the logo bigger.

I rescind my previous rescinding. I now approve this PR.

tethysplatform / tethys