search

tetsuo13 / Roundcube-Matomo-Tracking-Api-Plugin

Add Matomo (formerly Piwik) tracking server-side code to all requests in Roundcube
Other
1 stars 0 forks source link

Use setUserId instead of setCustomVariable #3

Closed GitPuffy closed 7 years ago

GitPuffy commented 7 years ago

In regards to https://github.com/tetsuo13/Roundcube-Piwik-Tracking-Api-Plugin/commit/e781ec202b8634b6a617263109b9fa9b4c9b3330

I changed the line $tracker->setCustomVariable($userEmailCustomVar, 'User email', $userEmail); to

$tracker->setUserId($userEmail);

And now Piwik records the email account as the user ID and displays the user account on the main Piwik dashboard view.

I don't know if this is any better in the long run from how you programmed it but I am passing along this tidbit in case you feel it is an even better solution and want to change it in a future release.

Thanks!

tetsuo13 commented 7 years ago

I misread your comment at first. Your suggestion looks like it may be a better solution than stuffing it into a custom variable. Let me experiment with it to see the differences in Piwik's reporting.

tetsuo13 commented 7 years ago

I've made the changes to use user ID instead and released version 2.0.0. This is much better than was implemented in #2 since it creates a profile in Piwik.

Thank you!