Closed Igoranze closed 6 years ago
Hmm... looks like there is more work for this fix... I will look into it tomorrow. Do you have any other ideas?
Merging #62 into develop will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## develop #62 +/- ##
======================================
Coverage 100% 100%
======================================
Files 12 12
Lines 1195 1211 +16
Branches 219 225 +6
======================================
+ Hits 1195 1211 +16
Impacted Files | Coverage Δ | |
---|---|---|
textile/core.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 674d514...2b90b80. Read the comment docs.
Hello, and thanks again, @Igoranze for your time and attention.
I'll admit I haven't really looked at this, but if I had to guess it might be due to the difficulty of handling those extended blocks. By the way, I ran your test through txstyle.org, and the result doesn't match your expectation in the test. I always use that as a reference for output.
Hello @ikirudennis ,
I'm continuing with this bug development. I'm not quite sure why the tests are not passing? While on my local machine everything seems fine... It looks like the <span class='caps'>...</span>
tags are not added here.
Also you said that the expected result does not mach that of txstyle.org. I suspect you mean the <p>...</p>
on each new line.
Have to look into that as well.
If you did manage to find a solution, please let me know.
Hi @ikirudennis,
I just pushed the last commit which fixes the <p>...</p>
(output is the same as txstyle.org)
Also there is no more double escaping on p.. multiline.
Merged multiple commits into one final commit
Thanks again, @Igoranze! Do you have more bugs you are planning to fix? Should I wait a little bit to push a new release?
Hi @ikirudennis,
No, I do not have plans to fix other bugs so you can go ahead and release. Thanks.
Hi,
Me agian. There is another error which happens if you use multiple line blocks on paragraph. If the input is:
The textile output is:
Here we can see that only the last
p..
is escaped good. Other (previous) paragraphs are double escaped:Added test and fix.