search

tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Add bisect_ppx coverage annotations #162

Closed dorranh closed 3 years ago

dorranh commented 3 years ago

Adds bisect_ppx coverage on / off annotations throughout the codebase to fix 1.) incorrect coverage reports which include call counts for type definitions due to interactions with ppx_deriving and 2.) unwanted coverage reporting for OCaml helpers which are only used in tests and not transpiled to Ligo.

Follows the solution discussed here: https://github.com/aantron/bisect_ppx/issues/196.

gkaracha commented 3 years ago

By the way @dorranh while going through the coverage report I realized that fraction_to_tez_ceil and fraction_to_nat_floor are not used at all, but they bring down the numbers for ratio.ml. After we merge this PR I'll remove them—we might be able to pass 90% :slightly_smiling_face:

dorranh commented 3 years ago

Thanks for the review! Good point about checkerMain.ml or checkerEntrypoints.ml - I created an issue for it (#163).