search

tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Rename Burrow.last_touched to Burrow.last_checker_timestamp #216

Closed gkaracha closed 3 years ago

gkaracha commented 3 years ago

Since it's original name and description were incorrect.

github-actions[bot] commented 3 years ago
Gas costs 13d60300a1563b2cad0cebce7117ad6df5876211 b1e362342011af5790d052b998c33310a13216c7 Diff
touch 537980 538005 25
transfer 39918 39924 6
update_operators 41662 41668 6
remove_liquidity 73784 73790 6
touch_burrow 44399 44405 6
withdraw_tez 57578 57584 6
burn_kit 51276 51282 6
mint_kit 52105 52111 6
deactivate_burrow 59021 59027 6
deposit_tez 53009 53015 6
add_liquidity 73532 73538 6
buy_kit 69518 69524 6
set_burrow_delegate 54681 54687 6
activate_burrow 53694 53700 6
create_burrow 47811 47817 6
sell_kit 68645 68651 6

Entrypoint sizes: No change.

gkaracha commented 3 years ago

Hmmm, I don't know, actually! When I fired that CI yesterday I didn't expect to see any differences so I am a little surprised about this too. Especially since the entrypoint sizes did not change. I restarted the CI, to see if we can get different results, but I'll look into gas calculation too :+1:

github-actions[bot] commented 3 years ago
Gas costs 13d60300a1563b2cad0cebce7117ad6df5876211 b1e362342011af5790d052b998c33310a13216c7 Diff
touch 537980 538005 25
transfer 39918 39924 6
update_operators 41662 41668 6
remove_liquidity 73784 73790 6
touch_burrow 44399 44405 6
withdraw_tez 57578 57584 6
burn_kit 51276 51282 6
mint_kit 52105 52111 6
deactivate_burrow 59021 59027 6
deposit_tez 53009 53015 6
add_liquidity 73532 73538 6
buy_kit 69518 69524 6
set_burrow_delegate 54681 54687 6
activate_burrow 53694 53700 6
create_burrow 47811 47817 6
sell_kit 68645 68651 6

Entrypoint sizes: No change.

gkaracha commented 3 years ago

Not that it matters, but am I correct to assume that the gas cost difference is only caused by last_checker_timestamp string being longer than last_touched, because they appear as annotations on generated code? Or is it just a result of non-deterministic compilation/execution?

The second run seems to give consistent results with the first run, so I'm inclined to think that it's because of the bigger annotations :thinking: I'll merge this one, but I am now wondering about other field names such as min_kit_for_unwarranted and perhaps other names relating to the liquidation auctions. Nah, probably the difference is negligible :slightly_smiling_face: