github-actions[bot]
commented
3 years ago | Gas costs | a8ffcd683ef7f91af8f06ea0be5f86eb1a53bb6e | 6d0d4a29a4ba1d16fb3a97b685d5f0ebd5b526b0 | Diff |
|---|---|---|---|
| checker%create_burrow | 6915 | 22048 | 15133 |
| checker%set_burrow_delegate | 9836 | 22663 | 12827 |
| checker%deactivate_burrow | 11279 | 23142 | 11863 |
| checker%withdraw_collateral | 11133 | 22783 | 11650 |
| checker%deposit_collateral | 8901 | 19749 | 10848 |
| checker%activate_burrow | 8921 | 19565 | 10644 |
| checker%touch | 30471 | 30618 | 147 |
| checker%mint_kit | 6926 | 7005 | 79 |
| checker%burn_kit | 7154 | 7232 | 78 |
| checker%remove_liquidity | 12584 | 12662 | 78 |
| checker%sell_kit | 11734 | 11812 | 78 |
| checker%buy_kit | 12502 | 12580 | 78 |
| checker%add_liquidity | 12654 | 12732 | 78 |
| checker%transfer | 6131 | 6207 | 76 |
| checker%touch_burrow | 5922 | 5998 | 76 |
| checker%update_operators | 5410 | 5486 | 76 |
| Entrypoint sizes | a8ffcd683ef7f91af8f06ea0be5f86eb1a53bb6e | 6d0d4a29a4ba1d16fb3a97b685d5f0ebd5b526b0 | Diff |
|---|---|---|---|
| withdraw_collateral | 1478 | 1329 | -149 |
| create_burrow | 1079 | 1223 | 144 |
| receive_slice_from_burrow | 119 | None | -119 |
| deactivate_burrow | 1605 | 1496 | -109 |
| touch | 56661 | 56559 | -102 |
| mark_for_liquidation | 17093 | 16992 | -101 |
| touch_liquidation_slices | 14465 | 14371 | -94 |
| liquidation_auction_claim_win | 1084 | 1129 | 45 |
| deposit_collateral | 1145 | 1176 | 31 |
| activate_burrow | 1274 | 1303 | 29 |
| buy_kit | 1350 | 1352 | 2 |
| sell_kit | 1346 | 1348 | 2 |
| add_liquidity | 1833 | 1835 | 2 |
| remove_liquidity | 1953 | 1955 | 2 |
| Test coverage | a8ffcd683ef7f91af8f06ea0be5f86eb1a53bb6e | 6d0d4a29a4ba1d16fb3a97b685d5f0ebd5b526b0 | Diff |
|---|---|---|---|
| checker.ml | 90.1 | 91.21 | 1.1099999999999994 |
| tok.ml | 97.3 | 96.77 | -0.5300000000000011 |
| checkerMain.ml | 92.86 | 93.02 | 0.1599999999999966 |
| common.ml | 97.87 | 97.89 | 0.01999999999999602 |
| TOTAL | 93.87 | 94.07 | 0.19999999999998863 |
gkaracha
First part of #213: integration of the tez wrapper into checker's workflow (for details see section "Changes for Checker" in https://github.com/tezos-checker/checker/issues/213#issuecomment-919838046). In essence this PR makes checker deal with FA2 exclusively. To keep CI green, usage of the tez wrapper is hardwired; adding the switch to be able to change the collateral type should be part of a separate PR. This PR is already pretty big.
Other changes:
from_andto_inTezWrapper.transferto save on gas costs (they were optional anyway).TezWrapper.transfer(transfer of zero tez should not fail due to non-originated vaults).tezWrapper.mlmore verbose to significantly reduce its gas costs (see bot message below).TezWrapper.transferis still pretty expensive which makes Checker's entrypoints expensive too. This we can improve incrementally after merging this PR.