tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Upgrade sandbox protocol to hangzhou #315

Closed dorranh closed 2 years ago

dorranh commented 2 years ago

Updated checker-builder to allow for code to be generated in a user-specified directory and used this within our Earthly build to eliminate the need for explicitly passing generated module names. After reading about buildkit more my hunch is that this will also fix the sporadic Error: build target: build main: bkClient.Build: failed to solve: duplicate output 0 errors we get when saving code which seem to primarily occur in the +generate-code target (https://github.com/earthly/earthly/issues/1406). The duplicate output code seems to be related to buildkit attempting to write outputs under the same path (even if they have different file names).

github-actions[bot] commented 2 years ago
Gas costs 89b06df5bdd9d8104c9b315476f81ac60a95cb01 2da86d0093af152bd8010d7e3b56482208f27de7 Diff
checker%touch 42430 None -42430
checker%deactivate_burrow 23439 None -23439
checker%withdraw_collateral 23080 None -23080
checker%create_burrow 22344 None -22344
checker%deposit_collateral 20046 None -20046
checker%activate_burrow 19862 None -19862
checker%set_burrow_delegate 18366 None -18366
checker%remove_liquidity 13295 None -13295
wtez%transfer 12777 None -12777
checker%add_liquidity 12600 None -12600
checker%buy_kit 12446 None -12446
checker%sell_kit 12445 None -12445
wtez%withdraw 9925 None -9925
wctez%mint 9149 None -9149
wctez%redeem 8677 None -8677
wtez%set_delegate 8459 None -8459
wtez%deposit 7540 None -7540
checker%burn_kit 7360 None -7360
checker%mint_kit 7132 None -7132
checker%transfer 6312 None -6312
checker%touch_burrow 6103 None -6103
checker%update_operators 5589 None -5589
wctez%transfer 4924 None -4924
mockFA2%transfer 4796 None -4796
wtez%update_operators 4221 None -4221
mockFA2%redeem 3691 None -3691
wctez%update_operators 3466 None -3466
mockFA2%mint 3456 None -3456
mockFA2%update_operators 3338 None -3338
Entrypoint sizes 89b06df5bdd9d8104c9b315476f81ac60a95cb01 2da86d0093af152bd8010d7e3b56482208f27de7 Diff
touch 56675 None -56675
mark_for_liquidation 17046 None -17046
touch_liquidation_slices 14350 None -14350
cancel_liquidation_slice 12122 None -12122
liquidation_auction_place_bid 2157 None -2157
remove_liquidity 1998 None -1998
add_liquidity 1878 None -1878
mint_kit 1531 None -1531
burn_kit 1514 None -1514
deactivate_burrow 1459 None -1459
buy_kit 1395 None -1395
sell_kit 1391 None -1391
withdraw_collateral 1292 None -1292
activate_burrow 1272 None -1272
create_burrow 1192 None -1192
deposit_collateral 1145 None -1145
liquidation_auction_claim_win 1096 None -1096
touch_burrow 611 None -611
set_burrow_delegate 457 None -457
update_operators 435 None -435
receive_price 289 None -289
receive_ctez_marginal_price 140 None -140
Test coverage 89b06df5bdd9d8104c9b315476f81ac60a95cb01 2da86d0093af152bd8010d7e3b56482208f27de7 Diff
cfmm.ml 100 None -100
fa2Implementation.ml 100 None -100
mem.ml 100 None -100
price.ml 100 None -100
cfmmTypes.ml 100 None -100
kit.ml 100 None -100
parameters.ml 100 None -100
fixedPoint.ml 100 None -100
fa2Ledger.ml 100 None -100
error.ml 100 None -100
ptr.ml 100 None -100
targetCalculation.ml 100 None -100
driftDerivative.ml 100 None -100
liquidationAuctionTypes.ml 100 None -100
tokenMetadata.ml 100 None -100
constants.ml 100 None -100
checkerEntrypoints.ml 97.73 None -97.73
burrow.ml 96.21 None -96.21
sliceList.ml 95.38 None -95.38
checker.ml 94.98 None -94.98
checkerMain.ml 93.33 None -93.33
avl.ml 91.05 None -91.05
common.ml 90.36 None -90.36
checkerTypes.ml 78.57 None -78.57
tok.ml 78.38 None -78.38
liquidationAuction.ml 77.83 None -77.83
getOracleEntrypoint.ml 75 None -75
ctok.ml 72.97 None -72.97
lqt.ml 72.97 None -72.97
mockFA2.ml 18.52 None -18.52
wctez.ml 14.29 None -14.29
burrowOrigination.ml 8 None -8
wtez.ml 4.78 None -4.78
TOTAL 81.89 None -81.89
github-actions[bot] commented 2 years ago
Gas costs 89b06df5bdd9d8104c9b315476f81ac60a95cb01 6948070a946685c313c88f255992ba9cbaee29e4 Diff
checker%deactivate_burrow 23439 14495 -8944
checker%withdraw_collateral 23080 14161 -8919
checker%set_burrow_delegate 18366 9679 -8687
checker%deposit_collateral 20046 11483 -8563
checker%activate_burrow 19862 11324 -8538
checker%create_burrow 22344 14788 -7556
wtez%transfer 12777 7384 -5393
checker%remove_liquidity 13295 8161 -5134
checker%buy_kit 12446 7350 -5096
checker%sell_kit 12445 7349 -5096
checker%add_liquidity 12600 7673 -4927
checker%touch 42430 46985 4555
wtez%withdraw 9925 5628 -4297
wtez%set_delegate 8459 4457 -4002
wctez%mint 9149 5448 -3701
wctez%redeem 8677 5000 -3677
wtez%deposit 7540 3933 -3607
checker%transfer 6312 3098 -3214
checker%touch_burrow 6103 2982 -3121
checker%update_operators 5589 2586 -3003
checker%mint_kit 7132 4324 -2808
checker%burn_kit 7360 4591 -2769
wtez%update_operators 4221 1694 -2527
wctez%transfer 4924 3036 -1888
mockFA2%transfer 4796 3025 -1771
wctez%update_operators 3466 1703 -1763
mockFA2%redeem 3691 1995 -1696
mockFA2%mint 3456 1785 -1671
mockFA2%update_operators 3338 1692 -1646

Entrypoint sizes: No change. Test coverage: No change.

dorranh commented 2 years ago

Very interestingly, it looks like these changes do indeed fix the duplicate output Earthly error which is blocking #314. Since this PR is based off of the same branch, and I would prefer not to waste so much CI time I'm going to go ahead and land this PR and close the other one.

gkaracha commented 2 years ago

Nice, thanks!

I am quite surprised btw by the gas cost differences; all gas costs dropped (some of them significantly), but those of checker%touch went up. Interesting how the new protocol changes the gas cost calculation :)