tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Switch ligo to vendored version #321

Closed dorranh closed 2 years ago

dorranh commented 2 years ago

Due to issues with configurations within ligo and the large size of Checker's entrypoints, we've had to compile the contract using a patched version of ligo. Thankfully, recent updates have made it possible to compile checker with upstream ligo. This PR switches over our builds to use upstream ligo instead of our fork.

One particularity of this PR is that since ligo does not currently publish arm binaries, we vendor / rebuild it within our Earthfile in order to continue to support M1 Mac users.

github-actions[bot] commented 2 years ago
Gas costs 5f8cedc05662b275deed75d663245e55f3ef005a 00c5d7c8e4673728aef459fec4c97e37ab86111e Diff
checker%touch 47061 None -47061
checker%create_burrow 14788 None -14788
checker%deactivate_burrow 14495 None -14495
checker%withdraw_collateral 14161 None -14161
checker%deposit_collateral 11483 None -11483
checker%activate_burrow 11324 None -11324
checker%set_burrow_delegate 9679 None -9679
checker%remove_liquidity 8163 None -8163
checker%add_liquidity 7675 None -7675
wtez%transfer 7384 None -7384
checker%sell_kit 7352 None -7352
checker%buy_kit 7352 None -7352
wtez%withdraw 5628 None -5628
wctez%mint 5448 None -5448
wctez%redeem 5000 None -5000
checker%burn_kit 4591 None -4591
wtez%set_delegate 4457 None -4457
checker%mint_kit 4324 None -4324
wtez%deposit 3933 None -3933
checker%transfer 3100 None -3100
wctez%transfer 3036 None -3036
mockFA2%transfer 3025 None -3025
checker%touch_burrow 2984 None -2984
checker%update_operators 2588 None -2588
mockFA2%redeem 1995 None -1995
mockFA2%mint 1785 None -1785
wctez%update_operators 1703 None -1703
wtez%update_operators 1694 None -1694
mockFA2%update_operators 1692 None -1692
Entrypoint sizes 5f8cedc05662b275deed75d663245e55f3ef005a 00c5d7c8e4673728aef459fec4c97e37ab86111e Diff
touch 56880 None -56880
mark_for_liquidation 17046 None -17046
touch_liquidation_slices 14350 None -14350
cancel_liquidation_slice 12122 None -12122
liquidation_auction_place_bid 2157 None -2157
remove_liquidity 1998 None -1998
add_liquidity 1878 None -1878
mint_kit 1531 None -1531
burn_kit 1514 None -1514
deactivate_burrow 1459 None -1459
buy_kit 1395 None -1395
sell_kit 1391 None -1391
withdraw_collateral 1292 None -1292
activate_burrow 1272 None -1272
create_burrow 1192 None -1192
deposit_collateral 1145 None -1145
liquidation_auction_claim_win 1096 None -1096
touch_burrow 611 None -611
set_burrow_delegate 457 None -457
update_operators 435 None -435
receive_price 289 None -289
receive_ctez_marginal_price 140 None -140
Test coverage 5f8cedc05662b275deed75d663245e55f3ef005a 00c5d7c8e4673728aef459fec4c97e37ab86111e Diff
cfmmTypes.ml 100 None -100
fixedPoint.ml 100 None -100
tokenMetadata.ml 100 None -100
parameters.ml 100 None -100
mem.ml 100 None -100
driftDerivative.ml 100 None -100
constants.ml 100 None -100
targetCalculation.ml 100 None -100
ptr.ml 100 None -100
kit.ml 100 None -100
cfmm.ml 100 None -100
fa2Ledger.ml 100 None -100
fa2Implementation.ml 100 None -100
liquidationAuctionTypes.ml 100 None -100
error.ml 100 None -100
checkerEntrypoints.ml 97.73 None -97.73
burrow.ml 96.21 None -96.21
sliceList.ml 95.38 None -95.38
checker.ml 94.98 None -94.98
checkerMain.ml 93.33 None -93.33
avl.ml 91.05 None -91.05
common.ml 90.36 None -90.36
checkerTypes.ml 78.57 None -78.57
tok.ml 78.38 None -78.38
liquidationAuction.ml 77.83 None -77.83
price.ml 76.92 None -76.92
getOracleEntrypoint.ml 75 None -75
ctok.ml 72.97 None -72.97
lqt.ml 72.97 None -72.97
mockFA2.ml 18.52 None -18.52
wctez.ml 14.29 None -14.29
burrowOrigination.ml 8 None -8
wtez.ml 4.78 None -4.78
TOTAL 81.88 None -81.88
github-actions[bot] commented 2 years ago
Gas costs 5f8cedc05662b275deed75d663245e55f3ef005a 63152f623fce8aec40f3ca9e37524bdc4598ca46 Diff
checker%touch 47061 None -47061
checker%create_burrow 14788 None -14788
checker%deactivate_burrow 14495 None -14495
checker%withdraw_collateral 14161 None -14161
checker%deposit_collateral 11483 None -11483
checker%activate_burrow 11324 None -11324
checker%set_burrow_delegate 9679 None -9679
checker%remove_liquidity 8163 None -8163
checker%add_liquidity 7675 None -7675
wtez%transfer 7384 None -7384
checker%sell_kit 7352 None -7352
checker%buy_kit 7352 None -7352
wtez%withdraw 5628 None -5628
wctez%mint 5448 None -5448
wctez%redeem 5000 None -5000
checker%burn_kit 4591 None -4591
wtez%set_delegate 4457 None -4457
checker%mint_kit 4324 None -4324
wtez%deposit 3933 None -3933
checker%transfer 3100 None -3100
wctez%transfer 3036 None -3036
mockFA2%transfer 3025 None -3025
checker%touch_burrow 2984 None -2984
checker%update_operators 2588 None -2588
mockFA2%redeem 1995 None -1995
mockFA2%mint 1785 None -1785
wctez%update_operators 1703 None -1703
wtez%update_operators 1694 None -1694
mockFA2%update_operators 1692 None -1692
Entrypoint sizes 5f8cedc05662b275deed75d663245e55f3ef005a 63152f623fce8aec40f3ca9e37524bdc4598ca46 Diff
touch 56880 53663 -3217
mark_for_liquidation 17046 16099 -947
touch_liquidation_slices 14350 13777 -573
cancel_liquidation_slice 12122 11559 -563
add_liquidity 1878 1835 -43
remove_liquidity 1998 1963 -35
sell_kit 1391 1356 -35
buy_kit 1395 1362 -33
liquidation_auction_place_bid 2157 2141 -16
create_burrow 1192 1182 -10
burn_kit 1514 1506 -8
touch_burrow 611 619 8
liquidation_auction_claim_win 1096 1090 -6
update_operators 435 431 -4
receive_price 289 287 -2
activate_burrow 1272 1274 2
deposit_collateral 1145 1147 2
Test coverage 5f8cedc05662b275deed75d663245e55f3ef005a 63152f623fce8aec40f3ca9e37524bdc4598ca46 Diff
burrowTypes.ml 0 100 100
fa2Interface.ml 0 100 100
liquidationAuctionPrimitiveTypes.ml 0 100 100
fa12Interface.ml 0 100 100
vaultTypes.ml 0 100 100
price.ml 76.92 100 23.08
checkerMain.ml 93.33 93.18 -0.14999999999999147
TOTAL 81.88 81.89 0.010000000000005116
github-actions[bot] commented 2 years ago
Gas costs 5f8cedc05662b275deed75d663245e55f3ef005a 1f5e1c2d6f343fafffc297145286cbef49e5e563 Diff
checker%touch 47061 47552 491
checker%create_burrow 14788 14777 -11
checker%add_liquidity 7675 7666 -9
checker%withdraw_collateral 14161 14153 -8
checker%sell_kit 7352 7344 -8
checker%buy_kit 7352 7345 -7
checker%deactivate_burrow 14495 14488 -7
checker%remove_liquidity 8163 8156 -7
checker%deposit_collateral 11483 11478 -5
checker%activate_burrow 11324 11319 -5
checker%set_burrow_delegate 9679 9675 -4
checker%burn_kit 4591 4588 -3
wtez%transfer 7384 7383 -1
wtez%deposit 3933 3932 -1
checker%touch_burrow 2984 2985 1
wctez%redeem 5000 5001 1
Entrypoint sizes 5f8cedc05662b275deed75d663245e55f3ef005a 1f5e1c2d6f343fafffc297145286cbef49e5e563 Diff
touch 56880 53675 -3205
mark_for_liquidation 17046 16099 -947
touch_liquidation_slices 14350 13777 -573
cancel_liquidation_slice 12122 11559 -563
add_liquidity 1878 1835 -43
remove_liquidity 1998 1963 -35
sell_kit 1391 1356 -35
buy_kit 1395 1362 -33
liquidation_auction_place_bid 2157 2141 -16
create_burrow 1192 1182 -10
touch_burrow 611 619 8
burn_kit 1514 1506 -8
liquidation_auction_claim_win 1096 1090 -6
update_operators 435 431 -4
activate_burrow 1272 1274 2
deposit_collateral 1145 1147 2
receive_price 289 287 -2
Test coverage 5f8cedc05662b275deed75d663245e55f3ef005a 1f5e1c2d6f343fafffc297145286cbef49e5e563 Diff
vaultTypes.ml 0 100 100
liquidationAuctionPrimitiveTypes.ml 0 100 100
fa2Interface.ml 0 100 100
fa12Interface.ml 0 100 100
burrowTypes.ml 0 100 100
price.ml 76.92 100 23.08
checkerMain.ml 93.33 93.18 -0.14999999999999147
TOTAL 81.88 81.91 0.030000000000001137
dorranh commented 2 years ago

Going to go ahead and land these changes. Note that we might want to homogenize our logic for pulling in ligo and flextesa since the latter is pulled within our Earthfile, but this is something we can tweak later as needed.