search

tfabris / BlueGigaEmpeg

Arduino module and daughter board to convert the empeg Car MP3 player to Bluetooth output.
GNU General Public License v3.0
0 stars 0 forks source link

Track titles stopped updating in one situation #9

Closed tfabris closed 6 years ago

tfabris commented 6 years ago

I had a situation where track titles stopped updating, the car stereo stopped querying for new track title data despite the fact that I was sending it notifications to that effect.

I've had this happen more than once since the new deduplication updates but I'm not certain it's caused by them.

Repro was a lot of messing with pause/play/next/prev in very quick succession.

Bug repro - head unit stopped querying for new track data.txt

tfabris commented 6 years ago

repro is pretty easy to make happen, just press top/left/right buttons very fast randomly with three fingers.

Stuff coming out of the serial port on the empeg still seems more or less OK but the headunit just gave up and stopped asking for track updates.

tfabris commented 6 years ago

Actually just pressing right button fast enough in quick succession will do it.

tfabris commented 6 years ago

Attaching a cleaner repro of the issue.

Bug Repro - Stereo stopped asking for track titles - Cleaner simpler repro.txt

tfabris commented 6 years ago

I'm pretty sure that this is a side effect of having to send a "TRACK_CHANGED" message to the headunit for every single line of the metadata that I receive. Most of the time it works fine unless you do a few track changes in quick succession and then the head unit just gives up and stops asking for track data.

This might be unique to my head unit, but it's worrisome and so I think we should just go back to not deduplicating any more.

tfabris commented 6 years ago

Fixed by Mark Lord in Hijack V524 by removing de-duplication.

It is still possible to overload the head unit enough to cause this to occur, but you have to jump forward in the tracks so quickly, and for so many tracks, that this is now a super unlikely occurrence.

Before, the issue could happen if you jumped forward only 4-5 tracks, now you have to spam it with dozens of quick jumps before it will start being a problem.

Issue is fixed to my satisfaction, closing issue.