tflori / angular-translator

translation module for angular
https://tflori.github.io/angular-translator/
MIT License
21 stars 6 forks source link

Angular 5 :( #64

Closed tflori closed 6 years ago

tflori commented 6 years ago

Contributions would be highly appreciated, thanks in advance!

What to say? It throws errors when compiling and the tests don't run when installing angular 5...

At the moment I'm not developing a frontend and I'm not up to date what has changed... I don't know if angular 5 has any advantages - it's just breaking my code.

tflori commented 6 years ago

small update: it's not throwing when compiling. it's throwing in browser because of the JitResolver is not in the public api anymore...

tflori commented 6 years ago

next error:

ERROR Error: StaticInjectorError[Injector]: 
  StaticInjectorError[Injector]: 
    NullInjectorError: No provider for Injector!
    at _NullInjector.get (webpack-internal:///../../../core/esm5/core.js:1118)
    at resolveToken (webpack-internal:///../../../core/esm5/core.js:1406)
    at tryResolveToken (webpack-internal:///../../../core/esm5/core.js:1348)
    at StaticInjector.get (webpack-internal:///../../../core/esm5/core.js:1219)
    at resolveToken (webpack-internal:///../../../core/esm5/core.js:1406)
    at tryResolveToken (webpack-internal:///../../../core/esm5/core.js:1348)
    at StaticInjector.get (webpack-internal:///../../../core/esm5/core.js:1219)
    at resolveNgModuleDep (webpack-internal:///../../../core/esm5/core.js:10780)
    at _createClass (webpack-internal:///../../../core/esm5/core.js:10821)
    at _createProviderInstance$1 (webpack-internal:///../../../core/esm5/core.js:10791)
View_AppComponent_Host_0 @ ng:///AppModule/AppComponent_Host.ngfactory.js:5
tflori commented 6 years ago

puh :sweat_smile: thats a bug of linking the project.. the node_modules exists and is used from webpack then the Injector exists two times and the StaticInjector only knows one of them...

tflori commented 6 years ago

@mouragz can you please try angular-translator@2.4.0-rc.1 ?

tflori commented 6 years ago

on angular-translator-demo it works: https://angular-translator-demo.my-first-domain.de/

mouragz commented 6 years ago

@tflori @BorntraegerMarc thank you so much it's working fine now 💯