search

tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries
MIT License
427 stars 86 forks source link

update Django to compatibility with 3.1.3 based on passing tests #58

Closed mekhami closed 3 years ago

mekhami commented 3 years ago

The only change I made was updating dev-requirements.txt, changing setup.py to add the supported version badge.

The tests pass just fine. If there's an incompatibility with 3.1.3 that needs to be addressed, I'm happy to continue that work on this MR, including a failing test case.

tfoxy commented 3 years ago

Great! Thanks for doing this. Can you change the double quotes changes to single quotes? Don't have much preference on one or the other, but the other files are using single quotes so I would prefer to maintain consistency here.

codecov-io commented 3 years ago

Codecov Report

Merging #58 (0bd40f2) into master (bf41b97) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files           6        6           
  Lines         325      325           
=======================================
  Hits          305      305           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf41b97...2c9289b. Read the comment docs.

mekhami commented 3 years ago

@tfoxy fixed the style conflict, updated to 3.1.4 which released yesterday, and this should be good to go.