search

tgjones / gemini

Gemini is an IDE framework similar in concept to the Visual Studio Shell. It uses AvalonDock and has an MVVM architecture based on Caliburn Micro.
Other
1.1k stars 298 forks source link

Fix for errors per appveyor build. #268

Closed nesterenko-kv closed 7 years ago

nesterenko-kv commented 7 years ago

*deleted*

tgjones commented 7 years ago

@nestquik thank you for taking the time to do this. But as far as I can tell, the build errors on AppVeyor are in the XNA project, and are caused by XNA not being installed on the AppVeyor build image. Although Gemini also has a MonoGame module, adding the MonoGame DLLs to the XNA project wouldn't help in this case.

I think the correct fix is to somehow install XNA 4.0 on the AppVeyor build image, using this redistributable and these steps.

nesterenko-kv commented 7 years ago

I can't say for sure, but after this changes AppVeyor correctly build the project as far as I can see: https://ci.appveyor.com/project/nestquik/gemini/build/1.0.7

P.S. It is necessary to observe...

tgjones commented 7 years ago

Interesting - indeed it does build. But I notice a number of warnings like this, so I'm not sure that the resulting XNA module DLL is bound to the correct reference:

C:\Program Files (x86)\MSBuild\12.0\bin\Microsoft.Common.CurrentVersion.targets(1697,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Microsoft.Xna.Framework.Graphics, Version=4.0.0.0, Culture=neutral, PublicKeyToken=842cf8be1de50553, processorArchitecture=x86". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\projects\gemini\src\Gemini.Demo.Xna\Gemini.Demo.Xna.csproj]
nesterenko-kv commented 7 years ago

It ceased to build the solution after this build (commit), although there is nothing critical was changed. Upd: just now compared the latest succesful build log with mine: image Seems like that is fine.

tgjones commented 7 years ago

I'm pretty sure it started failing when XNA was removed from AppVeyor's default build image. Prior to that, XNA was installed on AppVeyor's default build image.

nesterenko-kv commented 7 years ago

Okay, so we need to install XNA before build? I'll look for ways to do this.

nesterenko-kv commented 7 years ago

Works like a charm. Link to build.

tgjones commented 7 years ago

That's great, thank you! It will be so much easier to automatically deploy new NuGet versions safely once this is fixed.

One small request though - did you copy install-XNA.ps1 from somewhere? If so, please could you credit the source at the top of the file? Then I'll merge this.

nesterenko-kv commented 7 years ago

One small request though - did you copy install-XNA.ps1 from somewhere?

Yep, from here.

nesterenko-kv commented 7 years ago

Done, also I made some coloring for console log.

tgjones commented 7 years ago

Thank you so much, this is great.

nesterenko-kv commented 7 years ago

You're welcome! 😄