search

tgriesser / checkit

simple, flexible validations for node and the browser
MIT License
223 stars 53 forks source link

Compatibility for lodash 4.x #54

Closed sixpounder closed 8 years ago

sixpounder commented 8 years ago

Since .rest expects a function as input (formerly .restParam), I added an exception driven test to use _.tail instead.

package.json not updated, still using lodash 3. Travis build seems to be ok.

FredericHeem commented 8 years ago

+1

FredericHeem commented 8 years ago

It seems that rest in 4.x has a different meaning than the rest in 3.x, which was alias to tail. So rest shouldn't be called at all, using tail is fine for 3.x and 4.x.

vellotis commented 8 years ago

@rhys-vdw ping?

Whoaa512 commented 8 years ago

Don't believe this is valid any longer. Would recommend to close this PR since the code has changed to use _.tail where relevant.

sixpounder commented 8 years ago

Would have been nice to have some kind of feedback on this. Closing it anyway.