search

tgrosinger / advanced-tables-obsidian

Improved table navigation, formatting, and manipulation in Obsidian.md
GNU General Public License v3.0
2.15k stars 80 forks source link

Toolbar svg icons missing #214

Closed shel1kest0learn closed 10 months ago

shel1kest0learn commented 2 years ago

Describe the bug Missing toolbar icons display as question mark, even after Obsidian close and restart.

To Reproduce Steps to reproduce the behavior:

  1. Installed Obsidian 1.3.2 and Advanced Tables plugin 0.17.3 yesterday on Android 11.
  2. Left panel, Gear Icon, Mobile
  3. Manage Toolbar options
  4. Add "Move cursor out of table" and "Go to Previous cell" to toolbar
  5. Notice toolbar now has two question mark icons
  6. Exit Obsidian and restart. Icons still question marks.
  7. Repeat step 2 and 3
  8. Notice "Format table at the cursor" and "Format all tables in this file" also have question mark icons.

Not a dev, just a hobbyist, found that "icon:" is not specified for the two above in 4.

https://github.com/tgrosinger/advanced-tables-obsidian/blob/e09856cd6d8ee6707ce8fe08da8aa5fda07ace03/src/main.ts#L88

https://github.com/tgrosinger/advanced-tables-obsidian/blob/e09856cd6d8ee6707ce8fe08da8aa5fda07ace03/src/main.ts#L136

both with no corresponding svg.

The two above in 4., however, do execute the desired actions so the code appears to be correct.

tgrosinger commented 1 year ago

Can you please let me know if you are using any custom themes?

shel1kest0learn commented 10 months ago

Closed because don't use Obsidian anymore. And no, custom themes were not used.