th-ch / youtube-music

YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
https://th-ch.github.io/youtube-music/
MIT License
9.02k stars 512 forks source link

[Feature Request]: Always show volume slider #1703

Open eivindholvik opened 9 months ago

eivindholvik commented 9 months ago

Preflight Checklist

Problem Description

Great app!

Would like the ability to quickly change volume on screen 2. No need for two actions here imo :

Proposed Solution

Have an option to always show the volume, and remove class="expand-button style-scope ytmusic-player-bar" entirely. Or make it stay toggeled when clicked.

Alternatives Considered

Not do anything, it is strictly not a problem.

Additional Information

No response

ryanbuening commented 3 months ago

I would also like this feature. Would it make the most sense to put this under Options > Visual Tweaks?

Masood-ul-Rehman commented 3 months ago

@eivindholvik can I work on this, can you assign this issue to me

ArjixWasTaken commented 3 months ago

This can be achieved via a user theme

https://github.com/user-attachments/assets/f4611e2a-628f-4d69-8208-b93109d1ad3a

The css used is here

.volume-slider.ytmusic-player-bar {
    opacity: 1 !important;
}
ryanbuening commented 3 months ago

@ArjixWasTaken when using your style, you are unable to click and change the volume slider until you manually mute and unmute as you demonstrated in the video, which kind of defeats the purpose.

ArjixWasTaken commented 3 months ago

I didn't demonstrate that, I didn't even try changing the value of the slider before muting/unmuting.

I just found it weird that the mouse cursor was not a "pointer" when hovering over the slider, that's why I muted/unmuted

ryanbuening commented 3 months ago

Ah, I see. Well that is what the end result is when using that style, which solves the "Always show volume slider", but IMO isn't ideal since it requires additional user interaction before being able to change the volume.

ArjixWasTaken commented 3 months ago

A bit more css should fix this issue.