search

thaliproject / thali

Our root repository for all of our projects
MIT License
86 stars 13 forks source link

Fixed md lists - resolves #253 #258

Closed deadlyfingers closed 8 years ago

deadlyfingers commented 8 years ago

Fix for redcarpet markdown list formatting.

Review on Reviewable

msftclas commented 8 years ago

Hi @deadlyfingers, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

mpodwysocki commented 8 years ago

__config.yml, line 48 [r1] (raw file):_ As Yaron has mentioned we should switch over to the other project. I don't know if it'll do it for us or we have to

Comments from the review on Reviewable.io

mpodwysocki commented 8 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

deadlyfingers commented 8 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

__config.yml, line 48 [r1] (raw file):_ I think we have to switch it - I'll try changing to config to use kramdown instead then... https://github.com/thaliproject/thali/issues/257

Comments from the review on Reviewable.io

deadlyfingers commented 8 years ago

@mattpodwysocki ok, updated config to use kramdown instead of redcarpet and it seems to look the same on localhost. TOC still works and I've added a regex script to do the strikethrough effect on our stories.md as kramdown doesn't appear to support that option yet.

mpodwysocki commented 8 years ago

Reviewed 4 of 4 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io