search

thanhlong203 / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

Patch: add goog.structs.Map.toObject #173

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Extract a standard JS object representation of a Map object.
http://groups.google.com/group/closure-library-discuss/browse_thread/thread/5eb9
b5502f04b007

A patch to add the toObject() function is attached.

Original issue reported on code.google.com by google.a...@gtempaccount.com on 21 Jun 2010 at 6:36

Attachments:

GoogleCodeExporter commented 8 years ago 
Iterating on the object's keys gives false positives if Object.prototype is 
extended.
toObject() should be implemented similarly to getValues().

Original comment by pall...@google.com on 24 Jun 2010 at 11:43

GoogleCodeExporter commented 8 years ago 
what do you mean by getValues()? point me to some source file and I will 
reimplement the patch accordingly.

Original comment by george.m...@gmail.com on 25 Jun 2010 at 7:18

GoogleCodeExporter commented 8 years ago 
I was talking about the getValues method of goog.structs.Map at
http://closure-library.googlecode.com/svn/trunk/closure/goog/structs/map.js

Original comment by pall...@google.com on 25 Jun 2010 at 11:27

GoogleCodeExporter commented 8 years ago 
OK, I am attaching a patch with the new implementation. Hope it's OK this time.

Original comment by george.m...@gmail.com on 30 Jun 2010 at 7:28

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by pall...@google.com on 1 Jul 2010 at 11:44

GoogleCodeExporter commented 8 years ago 
Done in r156.

Original comment by pall...@google.com on 20 Jul 2010 at 8:53

GoogleCodeExporter commented 8 years ago

Original comment by pall...@google.com on 20 Jul 2010 at 8:54