search

thanos-community / obslytics

Tools and Services allowing seamless usage of Observability data from Prometheus, Thanos, Cortex, M3DB, Loki and more!
Apache License 2.0
31 stars 8 forks source link

Added e2e tests + small refactoring. #12

Closed bwplotka closed 4 years ago

bwplotka commented 4 years ago

cc @4n4nd

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

bwplotka commented 4 years ago

Almost there, does not work fully yet.

bwplotka commented 4 years ago

Works now well, please review (:

bwplotka commented 4 years ago

~docker not supported on those containers.... We will need to solve it somehow, maybe moving to Circle CLI ): Let's do this in separate PRs~

Fixing.

iNecas commented 4 years ago

Changes make sense to me (except some clarification needed on the multiple matchers).

When trying to run the e2e, I was getting cannot run command "docker network create" in rootless mode. @bwplotka is there a documentation on how it's expected to run these tests?

Also, do you know what happened to our CI?

iNecas commented 4 years ago

Btw. tested locally and I can confirm things work

bwplotka commented 4 years ago

When trying to run the e2e, I was getting cannot run command "docker network create" in rootless mode. @bwplotka is there a documentation on how it's expected to run these tests?

Looks like some limitation of the docker in your setup. Definitely new problem, let me know if you can figure this out. If not we can put some issue on Cortex lib (:

In terms of CI I am actively fighting with it.

bwplotka commented 4 years ago

CI green (:

Please PTAL tomorrow. Thanks for review so far :+1:

bwplotka commented 4 years ago

Good point forgot about it.

bwplotka commented 4 years ago

Fixed cc @iNecas

iNecas commented 4 years ago

Getting this in, we can do more changes in further PRs