search

thbe / puppet-ssmtp

Puppet ssmtp module
https://thbe.github.io/puppet-ssmtp/
GNU General Public License v3.0
1 stars 15 forks source link

Lintian fixes #8

Closed arioch closed 8 years ago

arioch commented 8 years ago

Fixes no less than 31 issues.

puppet-ssmtp (master) ☃  puppet-lint manifests | sort
manifests/config.pp - WARNING: ensure set to present on file resource on line 34
manifests/config.pp - WARNING: ensure set to present on file resource on line 42
manifests/config.pp - WARNING: variable contains a capital letter on line 15
manifests/config.pp - WARNING: variable contains a capital letter on line 15
manifests/config.pp - WARNING: variable contains a capital letter on line 16
manifests/config.pp - WARNING: variable contains a capital letter on line 16
manifests/config.pp - WARNING: variable contains a capital letter on line 17
manifests/config.pp - WARNING: variable contains a capital letter on line 17
manifests/config.pp - WARNING: variable contains a capital letter on line 33
manifests/config.pp - WARNING: variable contains a capital letter on line 38
manifests/config.pp - WARNING: variable contains a capital letter on line 39
manifests/config.pp - WARNING: variable contains a capital letter on line 41
manifests/config.pp - WARNING: variable contains a capital letter on line 46
manifests/config.pp - WARNING: variable contains a capital letter on line 47
manifests/init.pp - WARNING: variable contains a capital letter on line 70
manifests/init.pp - WARNING: variable contains a capital letter on line 70
manifests/init.pp - WARNING: variable contains a capital letter on line 71
manifests/init.pp - WARNING: variable contains a capital letter on line 71
manifests/init.pp - WARNING: variable contains a capital letter on line 72
manifests/init.pp - WARNING: variable contains a capital letter on line 72
manifests/package.pp - WARNING: variable contains a capital letter on line 14
manifests/params.pp - WARNING: variable contains a capital letter on line 21
manifests/params.pp - WARNING: variable contains a capital letter on line 24
manifests/params.pp - WARNING: variable contains a capital letter on line 25
manifests/params.pp - WARNING: variable contains a capital letter on line 26
manifests/params.pp - WARNING: variable contains a capital letter on line 27
manifests/params.pp - WARNING: variable contains a capital letter on line 35
manifests/params.pp - WARNING: variable contains a capital letter on line 36
manifests/params.pp - WARNING: variable contains a capital letter on line 37
manifests/service.pp - WARNING: missing trailing comma after last element on line 19
manifests/service.pp - WARNING: variable contains a capital letter on line 16
thbe commented 8 years ago

Since when is this test part of puppet-lint? I've checked locally and on forge:

https://forge.puppetlabs.com/thbe/ssmtp/scores

without complains. So guess this is a new test?

arioch commented 8 years ago

I think it's related to Puppet 4.

arioch commented 8 years ago

It's in the style guide though... https://docs.puppetlabs.com/guides/style_guide.html#variables

thbe commented 8 years ago

Ok, thanks for the hint (I didn't checked against P4 yet). I'll merge your request and put a reminder to myself to fix this in my other modules as well ;).