search

the-benchmarker / web-frameworks

Which is the fastest web framework?
MIT License
6.99k stars 667 forks source link

Make frameworks URL consistent for the exposed data #4236

Open SuspiciousLookingOwl opened 3 years ago

SuspiciousLookingOwl commented 3 years ago

For the exposed data (data.json and data.min.json), some frameworks uses their own web page as the framework URL (e.g. Fiber framework URL is https://gofiber.io/), and some frameworks uses their repository URL as the framework URL (e.g. Mark framework URL is https://github.com/passwalls/mark).

It will be nice to make all of the frameworks URL consistent and use the repository URL (whether it's GitHub or other VC) as the framework URL. This allows the website to easily fetches repository information from GitHub API (If the framework's repository are hosted in GitHub, which seems like most of them are)

For example fiber framework URL will be https://github.com/gofiber/fiber. I can easily extract the author / org name and repo name (gofiber/fiber) to fetch information from GitHub API -> https://api.github.com/repos/gofiber/fiber

SuspiciousLookingOwl commented 3 years ago

@waghanza any ETA for this?

I got some cool ideas to implement (related to https://github.com/the-benchmarker/website/issues/19)

waghanza commented 3 years ago

will try to do it this weekend ❤️

waghanza commented 3 years ago

sorry, I hadn't any bandwidth before. the idea is that some frameworks are not hosted by github / gitlab, so their is no "social" things like stars ...

SuspiciousLookingOwl commented 3 years ago

I think that's fine

  1. Use github repository URL if exists
  2. Otherwise, use something else (GitLab, custom website, etc.)
waghanza commented 3 years ago

I think you should keep information (vc and website, if exists), both have not the same goal, and it could be inaccurate to collapse those informations