the-couch / slater

🛠 Shopify development toolkit
https://slater.store/
346 stars 47 forks source link

'ignore' files being ignored but still get synced #108

Closed HarryFrancis closed 4 years ago

HarryFrancis commented 4 years ago

I'm using a pretty basic setup of Slater, with the default settings_data.json in the ignore field to prevent live settings being overridden.

When I run a sync, the settings file is being pushed up, along with anything else I put in the ignore field.

It's setup as below:


module.exports = {
  themes: {
    development: {
      id: 'xxxxxx',
      password: 'xxxxxx',
      store: 'xxxxx.myshopify.com',
      ignore: [
        'settings_data.json'
      ]
    }
  }
}
HarryFrancis commented 4 years ago

I've sorted this. I hadn't included the full path so it was looking in the root.

Maybe update the docs so that it reflects the default location of settings_data.json?

Working for anyone else needing help:


  themes: {
    development: {
      id: 'xxxxxx',
      password: 'xxxxxx',
      store: 'xxxxx.myshopify.com',
      ignore: [
        '**/config/settings_data.json'
      ]
    }
  }
}```