search

the-laurel / laurels

GNU General Public License v3.0
2 stars 31 forks source link

Added julietlizzy as volunteer #279

Closed julietlizzy closed 3 years ago

loredanacirstea commented 3 years ago

1) You don't need the image in the PR description - the PR description & comments on the PR are only for facilitating agreement on the actual content that is changed through commits. The image should only be in the changes: https://github.com/the-laurel/laurels/pull/279/files.

2)

Create only 1 Pull Request with both changes: a) edit https://github.com/the-laurel/laurels/blob/main/data/volunteersMap.json and add your chosen Ethereum address and username. b) add a png avatar in https://github.com/the-laurel/laurels/tree/main/data/images (< 500kB) in your repo. The file title must be your Ethereum address, like 0x90F79bf6EB2c4f870365E785982E1f101E93b906.png

Your PR now only contains point b) -the png avatar, but the title of the file is not conforming to our standard.

loredanacirstea commented 3 years ago

Looks good. I will merge this PR after you get Rinkeby ETH on your address (Step 1, point 4). You can also see your balance here: https://rinkeby.etherscan.io/address/0xD47b9b8B7EF578adb770cD2e34EB48D0F97B6682.

loredanacirstea commented 3 years ago

Closing this. It can be reopened when the volunteer decides to resume the process.