search

the-linux-schools-project / karoshi-client

Central repository for Karoshi Client development
http://linuxschools.org.uk
5 stars 6 forks source link

Move more preferences into mozilla.cfg #108

Closed Eldara98 closed 9 years ago

Eldara98 commented 9 years ago

Alongside moving as much Firefox configuration out of pre-session, this now uploads the entire Firefox directory to allow for preference permanance. The size of the uploaded directory has a balance to hopefully ensure it is not too large by locking extension installation with the xpinstall.enabled preference locked to false.

cc: @Xenopathic

RobinMcCorkell commented 9 years ago

@Eldara98 How goes the testing? This needs to be done ASAP...

RobinMcCorkell commented 9 years ago

Oops I got heredocs wrong... Using << 'EOF' will suppress parameter substitution, which we specifically don't want, and won't suppress leading tabs, so client-config is broken with this PR. The syntax needed is <<- EOF. Quoting the eof string suppresses parameter substitution, using <<- suppresses leading tabs.

Source: http://tldp.org/LDP/abs/html/here-docs.html

RobinMcCorkell commented 9 years ago

@Eldara98 Final call: is this working as expected in all areas?

Eldara98 commented 9 years ago

Yes, although one final test is necessary to check profile uploads to the server.

RobinMcCorkell commented 9 years ago

@Eldara98 Good point. Can you do that tomorrow?

Eldara98 commented 9 years ago

@Xenopathic Yes, I see no reason why not.