search

the-tcpdump-group / libpcap

the LIBpcap interface to various kernel packet capture mechanism
https://www.tcpdump.org/
Other
2.72k stars 855 forks source link

skip snprintf check for cross compile in cmake #1340

Closed junka closed 2 months ago

junka commented 4 months ago

just like what we did in configure.ac, skip check snprintf for cross compile.

infrastation commented 4 months ago

I understand on a Unix-like system with CMake 2.8.12 CMAKE_CROSSCOMPILING will not be defined and the workaround will not work, but will not affect other things.

junka commented 3 months ago

I understand on a Unix-like system with CMake 2.8.12 CMAKE_CROSSCOMPILING will not be defined and the workaround will not work, but will not affect other things.

Hi denis, Any better solution or what should I do for this pr.

infrastation commented 3 months ago

One thing in this change that is inconsistent with the Autoconf logic is that it would skip the test without printing the reason. Also there should be a change log entry in the "building and testing" section. Please have a look.

infrastation commented 2 months ago

Rebased and added the missing bits. This is going to be merged tomorrow.