the-teacher / rails7-startkit

Launch Rails with 1 shell command!
https://github.com/the-teacher/rails7-startkit
MIT License
578 stars 80 forks source link

Improvement to development with gems #22

Closed rodrigotoledo closed 1 year ago

rodrigotoledo commented 1 year ago
the-teacher commented 1 year ago

@rodrigotoledo you did a great job! Just amazing PR.

The only thing here, - I'm going to add tools step by step. The project is created for educational purposes. Every release - is a small piece of a functionality with an article in releases.

Great if you can split things here into smaller PR and we can merge them step by step with providing articles.

Anyway, even if you are not going to do it -- I will use your PR for doing it.

Fantastic Job! Thank you a lot!

the-teacher commented 1 year ago

@rodrigotoledo

Just to let you know

[added]

[rejected]

[to be added]

You have done a great job! Thank you for inspiration and great examples!

Sorry didn't merge your code directly, because I'm try in to add things in small parts.

rodrigotoledo commented 1 year ago

Thank you for your email, I understand the points and you are right. I have just one question: why use bootstrap and not other css framework like tailwind?

On Sat, 25 Feb 2023 at 16:11 Ilya N. Zykin @.***> wrote:

@rodrigotoledo https://github.com/rodrigotoledo

Just to let you know

[added]

  • simplecov in the project now
  • changes in Database config for different env are also provided

[rejected]

  • Database cleaner, if I got it right it brings more problems than solutions. I'm not going to add it
  • gem bullet is very specific thing, for now I'm not going to add it

[to be added]

  • FactoryBot will be installed soon
  • Bootstrap I'm going to add soon

You have done a great job! Thank you for inspiration and great examples!

Sorry didn't merge your code directly, because I'm try in to add things in small parts.

— Reply to this email directly, view it on GitHub https://github.com/the-teacher/rails7-startkit/pull/22#issuecomment-1445184855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFJGE653OUGKSFX3FQO4DWZJKNBANCNFSM6AAAAAAVACIZY4 . You are receiving this because you were mentioned.Message ID: @.***>

--

Atenciosamente,

UserMaster.find_by_username('rodrigo-toledo').do |rodrigo|

*"*Não te preocupes com quem te persegues Se preocupe com quem te distrai "