search

the-teacher / the_sortable_tree

Nested Set + Drag&Drop GUI. Very fast! Best render helper! 2000 nodes/sec. Ready for rails 4
MIT License
558 stars 127 forks source link

SCSS files renamed because of deprecation warning #70

Closed aypn0s closed 9 years ago

melhotiby commented 9 years ago

@the-teacher - where is this at?

the-teacher commented 9 years ago

@railsdevmatt hello! Sorry, I cant understand what do you mean. Could you explain?

melhotiby commented 9 years ago

@the-teacher - I am using release 2.5.0 which does not have the .css.scss to .scss conversion and I run into deprecation warnings like

DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/sortable_tree.css.scss to /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/sortable_tree.scss. (called from _app_views_layouts_application_html_haml__382310849341476857_70125746854620 at /Users/matt/Sites/project/app/views/layouts/application.html.haml:20)
DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/nested_options.css.scss to /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/nested_options.scss. (called from _app_views_layouts_application_html_haml__382310849341476857_70125746854620 at /Users/matt/Sites/project/app/views/layouts/application.html.haml:20)
DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/sortable_tree.css.scss to /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/sortable_tree.scss. (called from _app_views_layouts_application_html_haml__382310849341476857_70125746854620 at /Users/matt/Sites/project/app/views/layouts/application.html.haml:20)
DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/nested_options.css.scss to /Users/matt/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/the_sortable_tree-2.5.0/app/assets/stylesheets/nested_options.scss. (called from _app_views_layouts_application_html_haml__382310849341476857_70125746854620 at /Users/matt/Sites/project/app/views/layouts/application.html.haml:20)

Merging this PR into master and cutting a new release will solve that

the-teacher commented 9 years ago

@railsdevmatt doh. Looks ugly after years of rails conventions about CSS naming and so on. But ok. It looks like common practice for now. Let it be. Merge.