search

theabolton / whysynth

Versatile multi-mode DSSI softsynth.
http://smbolton.com/whysynth.html
GNU General Public License v2.0
39 stars 12 forks source link

Extra filters #1

Closed zyx closed 12 years ago

zyx commented 12 years ago

Hey Sean, good to see you've moved Whysynth's source onto Github. I thought I'd get my tinkering into a git repo & push some branches for you to take a look at. This branch is built on top of 3 others, so it may be worth looking at the previous branches rather than trying to review 23 individual commits.

Not sure if this stuff is what you've got in mind for Whysynth, but it helps fill out the 'filter type' knob on my controller: controller

theabolton commented 12 years ago

Hi Luke, It's great to see you've reached the hardware stage with your controller! I see some good stuff in your pull request, plus some things I need to spend some more time looking at. Hopefully I'll get a chance to do that next week. Thanks! -Sean

theabolton commented 12 years ago

Luke, nice work on the new filter modes. I cherry-picked those changes, which means that I used your changes, comments, and authorship info, but github doesn't recognize that (many of them) are the same commits as in your branch. Kind of a mess -- I wonder if there's a better way to do the cherry-picking with git. Anyway, the filter code is committed to master now. I left out the test code -- it looked like a cool way to make sure you didn't break anything while you did the refactoring, but it actually failed on my machine, because of subtle differences in the way it does floating-point math. Thanks again for the contribution. Oh, and if you have a chance to make a video of your controller in use, I'd love to see it! -Sean