thecynic / pylutron

MIT License
33 stars 43 forks source link

Occupancy for everything? #71

Open wkearney99 opened 2 years ago

wkearney99 commented 2 years ago

In Ra2 there's occupancy for areas that have their sensors, and then there's also a 'rollback' timer. It's possible to have a room set with a rollback timer, and a value that executes a vacancy scene when the timer expires. This is a handy way to allow manually turning on a light that's part of a rollback group and have it (and anything else in the rollback group) automatically set to a scene once the timer expires. Note I mentioned 'set to a scene' not just 'turned off' as you could have one area time out and perhaps change values in another. Like turning off a bathroom, and then setting an adjacent hallway light to a low dimmed level like for a nightlight.

Anyway, I noticed in HA occupancy entities were being picked up for EVERY room, not just ones with a motion sensor or a rollback. I'm not sure that's correct. I can, of course, just disable the entities where there's not actually a sensor/rollback but this gets tedious when you have dozens of them.

Should the importing routine be creating binary_sensor._occupancy for every room? Or only just ones with an actual sensor or rollback?

JonGilmore commented 2 years ago

Hm, you're absolutely correct - I never noticed this issue because I have quite a few lutron motions. I'll see if I can take a look at this at some point here, thanks for reporting it

JonGilmore commented 2 years ago

I've got a PR up @wkearney99 to fix this, would love it if you could give some feedback and test it out. I did some basic testing on my system and things look OK, but 🤷