search

thedevdojo / voyager

Voyager - The Missing Laravel Admin
https://voyager.devdojo.com
MIT License
11.72k stars 2.67k forks source link

Browse view uses deprecated Carbon "formatLocalized" function #5701

Open neurotools opened 1 year ago

neurotools commented 1 year ago

Laravel version

9.24.0

PHP version

8.1.12

Voyager version

1.6.x-dev#2812898464f279e14ad6e9f89e2e8bf992e00c91

Database

MySQL 8.0.3.1

Description

Browse view uses formatLocalized function from Carbon that is marked as "deprecated" since 2.55.0 (see https://github.com/briannesbitt/Carbon/blob/889546413c97de2d05063b8cb7b193c2531ea211/src/Carbon/Traits/Date.php#L1877).

Function call location: https://github.com/the-control-group/voyager/blob/b12253e98cc67370b8a80b8a4d45db7ad230b269/resources/views/bread/browse.blade.php#L166

Steps to reproduce

Use any model with timestamps on the browse view and see the Laravel logs (if configured to log warnings). You will see something like:

laravel.WARNING: Function strftime() is deprecated in /home/project/vendor/nesbot/carbon/src/Carbon/Traits/Date.php on line 1853

Expected behavior

As recommended in Carbon, just use isoFormat instead.

Screenshots

No response

Additional context

No response

neurotools commented 1 year ago

Ups.. Duplicated #5594 issue...