search

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt
GNU General Public License v3.0
440 stars 122 forks source link

use certbot instead of letsencrypt #36

Closed gnpar closed 8 years ago

gnpar commented 8 years ago

Eff changed the name of the letsencrypt client to certbot, newer versions are available under the new name.

thefinn93 commented 8 years ago

Doesn't the pypi certbot package just depend on the letsencrypt package? As I understood it that's where the fun parts were.

gnpar commented 8 years ago

They are a few version numbers appart on the pypi repo.

Anyway, right after sending the PR I realized I had only tested the install procedure and not the cert generation.

It probably works, but it might be better to replace the calls to letsencrypt with certbot and do full testing.

I'll do that and get back to you.

gnpar commented 8 years ago

It seems I was wrong about the version difference, and my changes don't fully work (you have to replace every instance of bin/letsencrypt with bin/certbot).

I'm killing this PR now, sorry for the noise.