search

theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello
GNU General Public License v3.0
146 stars 163 forks source link

Should the foreman_hostgroup module be foreman_host_group? #475

Closed sean797 closed 4 years ago

sean797 commented 4 years ago
SUMMARY

Does foreman_hostgroup fit in with the other modules? All of which have an underscore between words

The API uses hostgroup https://github.com/theforeman/foreman/blob/ae96cb70130968bdcc8b7a9a9af7edc7c6e0d9a8/config/routes/api/v2.rb#L142

The UI says Host Group:

image

Or maybe it doesn't matter that we are slightly inconsistent?

evgeni commented 4 years ago

Operatingsystem had an underscore and we got rid of it.

I think we've been following the API names as much as possible, so I'd vote for keeping it hostgroup.

evgeni commented 4 years ago

@sean797 any objections on closing this after 2 weeks?

sean797 commented 4 years ago

:+1: