theforeman / foreman_fog_proxmox

Foreman plugin to add Proxmox compute resource based on fog-proxmox gem
GNU General Public License v3.0
105 stars 30 forks source link

500 on association of proxmpx vm with foreman host #222

Closed bk-lg closed 1 year ago

bk-lg commented 2 years ago

Describe the bug If I try to associate a vm with a foreman host the frontend reports a 500 error and it won't work. Maybe something similar to #220 ?

To Reproduce Steps to reproduce the behavior:

Expected behavior It should appear a screen or menu to associate the VMs

Screenshots image

Desktop (please complete the following information):

Foreman: Foreman: 3.11 foreman_fog_proxmo: 0.14.0

Additional context

2022-02-02T19:37:41 [I|app|1d4a0450] Started PUT "/compute_resources/2-pve-location-net-domain-tld/associate?compute_resource_id=2-pve-location-net-domain-tld" for 10.10.6.15 at 2022-02-02 19:37:41 +0100 2022-02-02T19:37:41 [I|app|1d4a0450] Processing by ComputeResourcesController#associate as HTML 2022-02-02T19:37:41 [I|app|1d4a0450] Parameters: {"authenticity_token"=>"censored==", "compute_resource_id"=>"2-pve-location-net-domain-tld", "id"=>"2-pve-location-net-domain-tld"} 2022-02-02T19:37:45 [W|app|1d4a0450] no implicit conversion of Integer into String 2022-02-02T19:37:45 [I|app|1d4a0450] Backtrace for 'no implicit conversion of Integer into String' error (TypeError): no implicit conversion of Integer into String 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/models/concerns/host_ext/proxmox/for_vm.rb:27:in +' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/models/concerns/host_ext/proxmox/for_vm.rb:27:infor_vm_uuid' 1d4a0450 | /usr/share/foreman/app/models/host.rb:15:in method_missing' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/services/concerns/foreman_fog_proxmox/compute_resource_host_associator.rb:29:inblock in associate_hosts' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/models/foreman_fog_proxmox/vms.rb:25:in block in each' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/models/foreman_fog_proxmox/vms.rb:25:ineach' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/models/foreman_fog_proxmox/vms.rb:25:in each' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/foreman_fog_proxmox-0.14.0/app/services/concerns/foreman_fog_proxmox/compute_resource_host_associator.rb:28:inassociate_hosts' 1d4a0450 | /usr/share/foreman/app/controllers/compute_resources_controller.rb:52:in associate' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal/basic_implicit_render.rb:6:insend_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/abstract_controller/base.rb:195:in process_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal/rendering.rb:30:inprocess_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/abstract_controller/callbacks.rb:42:in block in process_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:112:inblock in run_callbacks' 1d4a0450 | /usr/share/foreman/app/controllers/concerns/foreman/controller/timezone.rb:10:in set_timezone' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:121:inblock in run_callbacks' 1d4a0450 | /usr/share/foreman/app/models/concerns/foreman/thread_session.rb:32:in clear_thread' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:121:inblock in run_callbacks' 1d4a0450 | /usr/share/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in set_topbar_sweeper_controller' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:121:inblock in run_callbacks' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/audited-4.10.0/lib/audited/sweeper.rb:14:in around' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:121:inblock in run_callbacks' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/audited-4.10.0/lib/audited/sweeper.rb:14:in around' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:121:inblock in run_callbacks' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:139:in run_callbacks' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/abstract_controller/callbacks.rb:41:inprocess_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal/rescue.rb:22:in process_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal/instrumentation.rb:33:inblock in process_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/notifications.rb:180:in block in instrument' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/notifications/instrumenter.rb:24:ininstrument' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/notifications.rb:180:in instrument' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal/instrumentation.rb:32:inprocess_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal/params_wrapper.rb:245:in process_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activerecord-6.0.3.7/lib/active_record/railties/controller_runtime.rb:27:inprocess_action' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/abstract_controller/base.rb:136:in process' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionview-6.0.3.7/lib/action_view/rendering.rb:39:inprocess' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal.rb:190:in dispatch' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_controller/metal.rb:254:indispatch' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/routing/route_set.rb:50:in dispatch' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/routing/route_set.rb:33:inserve' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/journey/router.rb:49:in block in serve' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/journey/router.rb:32:ineach' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/journey/router.rb:32:in serve' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/routing/route_set.rb:834:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/apipie-dsl-2.4.0/lib/apipie_dsl/static_dispatcher.rb:67:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/apipie-rails-0.5.19/lib/apipie/static_dispatcher.rb:66:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/apipie-rails-0.5.19/lib/apipie/extractor/recorder.rb:137:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/static.rb:126:incall' 1d4a0450 | /usr/share/foreman/lib/foreman/middleware/libvirt_connection_cleaner.rb:9:in call' 1d4a0450 | /usr/share/foreman/lib/foreman/middleware/telemetry.rb:10:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/apipie-rails-0.5.19/lib/apipie/middleware/checksum_in_headers.rb:27:in call' 1d4a0450 | /usr/share/foreman/lib/foreman/middleware/catch_json_parse_errors.rb:9:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/tempfile_reaper.rb:15:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/etag.rb:27:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/conditional_get.rb:40:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/head.rb:12:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/http/content_security_policy.rb:18:in call' 1d4a0450 | /usr/share/foreman/lib/foreman/middleware/logging_context_session.rb:22:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:266:in context' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:260:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/cookies.rb:648:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/callbacks.rb:27:inblock in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/callbacks.rb:101:in run_callbacks' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/callbacks.rb:26:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/debug_exceptions.rb:32:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/show_exceptions.rb:33:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/railties-6.0.3.7/lib/rails/rack/logger.rb:37:incall_app' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/railties-6.0.3.7/lib/rails/rack/logger.rb:28:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/sprockets-rails-3.4.2/lib/sprockets/rails/quiet_assets.rb:13:incall' 1d4a0450 | /usr/share/foreman/lib/foreman/middleware/logging_context_request.rb:11:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/remote_ip.rb:81:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/request_id.rb:27:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/method_override.rb:24:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/runtime.rb:22:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/activesupport-6.0.3.7/lib/active_support/cache/strategy/local_cache_middleware.rb:29:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/executor.rb:14:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/static.rb:126:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/sendfile.rb:110:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/actionpack-6.0.3.7/lib/action_dispatch/middleware/host_authorization.rb:76:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/secure_headers-6.3.3/lib/secure_headers/middleware.rb:11:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/railties-6.0.3.7/lib/rails/engine.rb:527:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/railties-6.0.3.7/lib/rails/railtie.rb:190:in public_send' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/railties-6.0.3.7/lib/rails/railtie.rb:190:inmethod_missing' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/urlmap.rb:74:in block in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/urlmap.rb:58:ineach' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/rack-2.2.3/lib/rack/urlmap.rb:58:in call' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/puma-5.6.1/lib/puma/configuration.rb:252:incall' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/puma-5.6.1/lib/puma/request.rb:77:in block in handle_request' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/puma-5.6.1/lib/puma/thread_pool.rb:340:inwith_force_shutdown' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/puma-5.6.1/lib/puma/request.rb:76:in handle_request' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/puma-5.6.1/lib/puma/server.rb:441:inprocess_client' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/puma-5.6.1/lib/puma/thread_pool.rb:147:in block in spawn_thread' 1d4a0450 | /usr/share/foreman/vendor/ruby/2.5.0/gems/logging-2.3.0/lib/logging/diagnostic_context.rb:474:inblock in create_with_logging_context' 2022-02-02T19:37:45 [I|app|1d4a0450] Rendering common/500.html.erb within layouts/application 2022-02-02T19:37:45 [I|app|1d4a0450] Rendered common/500.html.erb within layouts/application (Duration: 4.3ms | Allocations: 1062) 2022-02-02T19:37:45 [I|app|1d4a0450] Rendered layouts/_application_content.html.erb (Duration: 5.1ms | Allocations: 4961) 2022-02-02T19:37:45 [I|app|1d4a0450] Rendering layouts/base.html.erb 2022-02-02T19:37:45 [I|app|1d4a0450] Rendered layouts/base.html.erb (Duration: 8.6ms | Allocations: 6423) 2022-02-02T19:37:45 [I|app|1d4a0450] Completed 500 Internal Server Error in 3657ms (Views: 26.7ms | ActiveRecord: 40.7ms | Allocations: 533339)

Foreman version: 3.1.1 Plugins:

tristanrobert commented 1 year ago

fixed with https://github.com/theforeman/foreman_fog_proxmox/pull/223