search

theforeman / foreman_fog_proxmox

Foreman plugin to add Proxmox compute resource based on fog-proxmox gem
GNU General Public License v3.0
105 stars 30 forks source link

link hosts and vms by lower case MAC + fix 500 #223

Closed Hedius closed 1 year ago

Hedius commented 2 years ago

Proxmox 7.1-10 Lastest fog_proxmox Latest stable foreman: 3.1.2

I've found the following problem while linking an existing host to a VM

The puppet facts store the MAC in lower case.

The proxmox compute resource (this plugin) pulls the MAC in upper case from the Proxmox API (or Proxmox provides it in upper case)

Therefore, it is not possible to link an existing host with a proxmox host. (Since the comparison is case-sensitive)

The attached commit converts both values to lower case before attempting to associate the different objects. (Works again)

Furthermore, d30e1c435c2d456b9519bc74b407f6aa89a256e2 converts the identity (int) to a string to fix a 500 when clicking on the “Associate VMs” button. Similar to #220

Hedius commented 2 years ago

Update: Furthermore, d30e1c435c2d456b9519bc74b407f6aa89a256e2 converts the identity (int) to a string to fix a 500 when clicking on the “Associate VMs” button. Similar to #220